Open
Conversation
API MuncherWhat We're Looking For
|
CheezItMan
reviewed
May 9, 2018
| end | ||
|
|
||
| def index | ||
| @recipes = ApiMuncherWrapper.search_recipes(params[:search]).paginate(:page => params[:page],:per_page => 10) |
There was a problem hiding this comment.
You need to have some sort of check to verify that you get an array back here.
| it "will return an empty array if recipe does not exist" do | ||
|
|
||
| VCR.use_cassette("recipes") do | ||
| recipes = ApiMuncherWrapper.search_recipes("abbbcd1234567") |
There was a problem hiding this comment.
Your API returns nil instead of an empty array
| get recipes_path, params: { search: "pesto" } | ||
| must_respond_with :success | ||
|
|
||
| get recipes_path, params: { search: " " } |
There was a problem hiding this comment.
No error handling for if the search returns no results?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions